Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.29.x] Add null check before casting attribute value to string #6824

Open
wants to merge 3 commits into
base: 2.29.x
Choose a base branch
from
Open

[2.29.x] Add null check before casting attribute value to string #6824

wants to merge 3 commits into from
+12 −4

Conversation

alexabird
Copy link
Contributor

@alexabird alexabird commented Dec 18, 2024 •
edited
Loading

To hot deploy these changes:

  1. build ddf/catalog/transformer/catalog-transformer-csv-common
  2. build ddf/catalog/transformer/catalog-transformer-csv-queryresponse
  3. build ddf/catalog/transformer/catalog-transformer-xlsx
  4. build ddf/catalog/transformer/catalog-transformer-rtf
  5. copy the target jars from steps 2, 3 and 4 into the running instance's deploy dir

@alexabird
Copy link
Contributor Author

build now

@alexabird alexabird changed the title Add null check before casting attribute value to string [2.29.x] Add null check before casting attribute value to string Dec 18, 2024
@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@alexabird
Copy link
Contributor Author

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

nnld
nnld approved these changes Dec 20, 2024
View reviewed changes
Copy link

@nnld nnld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix has been verified on the client env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkirksey zkirksey zkirksey left review comments

@nnld nnld nnld approved these changes

@AzGoalie AzGoalie Awaiting requested review from AzGoalie

@malmgrens4 malmgrens4 Awaiting requested review from malmgrens4

@glenhein glenhein Awaiting requested review from glenhein

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexabird @cxddfbot @nnld @zkirksey